Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the dependency of the month filter #7721

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: remove the dependency of the month filter #7721

merged 1 commit into from
Jul 11, 2024

Conversation

Startrekzky
Copy link
Contributor

@Startrekzky Startrekzky commented Jul 11, 2024 •
edited
Loading

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

fix: remove the dependency of the month filter in the Engineering Overview dashboard

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. component/ext This issue or PR relates to external components, such as Grafana needs-cherrypick-v1.0 type/bug This issue is a bug labels Jul 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 11, 2024
@abeizn abeizn merged commit 963d42e into apache:main Jul 11, 2024
11 checks passed
@Startrekzky Startrekzky deleted the fix-eng-overview branch July 11, 2024 11:12
Startrekzky added a commit to merico-dev/lake that referenced this pull request Jul 11, 2024
@Startrekzky @merico-devlake
fix: remove the dependency of the month filter (apache#7721)
3b0a158 
Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
Startrekzky added a commit that referenced this pull request Jul 11, 2024
@Startrekzky @merico-devlake
fix: remove the dependency of the month filter (#7721) (#7722)
68a19ed 
Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeizn abeizn abeizn approved these changes

Assignees
No one assigned
Labels
component/ext This issue or PR relates to external components, such as Grafana lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 size:M This PR changes 30-99 lines, ignoring generated files. type/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Startrekzky @abeizn @merico-devlake